Removed org.apache.druid.discovery.BrokerClient by switching to org.apache.druid.sql.client.BrokerClient. Also upgraded SegmentLoadStatusFetcherTest to reflect changes. #17470
+142
−124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
SegmentLoadStatusFetcher
to use the new SQL package'sBrokerClient
implementation, replacing the deprecated discovery-basedBrokerClient
. This change improves code maintainability and aligns with Druid's ongoing modernization efforts.Migrated BrokerClient Implementation
org.apache.druid.discovery.BrokerClient
withorg.apache.druid.sql.client.BrokerClient
SqlTaskStatus
StringUtils.format
Updated Test Framework
SegmentLoadStatusFetcherTest
to properly mock SQL task lifecycleRelease note
Migrated Multi-Stage Query's segment load status checking to use the new SQL package's BrokerClient, removing dependency on the deprecated discovery-based implementation. This change improves code maintainability and provides better SQL task state handling.
Key changed/added classes in this PR
org.apache.druid.msq.exec.SegmentLoadStatusFetcher
org.apache.druid.msq.exec.SegmentLoadStatusFetcherTest
This PR has:
Design Decisions:
Task State Management:
TaskState
for explicit state trackingTest Structure:
Error Handling:
SqlTaskStatus